autopilot/kicad
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SHAPE_ARC::GetCentralAngle(): better algo to calculate actual arc.

Browse Source 
The old algo worked fine only if the arc "middle point" was on the middle
of the arc. This algo just needs a "middle point" on the arc, not necessary
exactly near the middle of the arc.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/21035
This commit is contained in:
jean-pierre charras
2025-06-01 10:01:03 +02:00
parent 65dfee161b
commit 2124f2b846
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/kimath/src/geometry/shape_arc.cpp
+17 -3
View File
@@ -870,10 +870,24 @@ EDA_ANGLE SHAPE_ARC::GetCentralAngle() const
return ANGLE_360;
VECTOR2L center = GetCenter();
EDA_ANGLE angle1 = EDA_ANGLE( m_mid - center ) - EDA_ANGLE( m_start - center );
EDA_ANGLE angle2 = EDA_ANGLE( m_end - center ) - EDA_ANGLE( m_mid - center );
EDA_ANGLE angle = EDA_ANGLE( m_end - center ) - EDA_ANGLE( m_start - center );
return angle1.Normalize180() + angle2.Normalize180();
// Using only m_start and m_end arc points to calculate the central arc is not enough
// there are 2 arcs having the same center and end points.
// Using the middle point is mandatory to know what arc is the right one.
// IsClockwise() uses m_start, m_middle and m_end arc points to know the arc orientation
if( !IsClockwise() )
{
if( angle < ANGLE_0 )
angle += ANGLE_360;
}
else
{
if( angle > ANGLE_0 )
angle -= ANGLE_360;
}
return angle;
}