Set VIATYPE setting via property type as well

pcbnew/pcb_track.cpp

@@ -1348,27 +1348,19 @@ void PCB_VIA::SetTopLayer( PCB_LAYER_ID aLayer )
     if( aLayer == Padstack().Drill().end )
         return;
 
-    if( IsCopperLayerLowerThan( aLayer, Padstack().Drill().end ) )
-    {
-        std::swap( aLayer, Padstack().Drill().end );
-    }
-
     Padstack().Drill().start = aLayer;
+    SanitizeLayers();
 }
 
 
 void PCB_VIA::SetBottomLayer( PCB_LAYER_ID aLayer )
 {
     // refuse invalid via
-    if( aLayer == Padstack().Drill().start || !IsCopperLayerLowerThan( aLayer, Padstack().Drill().start ) )
+    if( aLayer == Padstack().Drill().start )
         return;
 
-    if( !IsCopperLayerLowerThan( aLayer, Padstack().Drill().start ) )
-    {
-        std::swap( aLayer, Padstack().Drill().start );
-    }
-
     Padstack().Drill().end = aLayer;
+    SanitizeLayers();
 }
 
 

pcbnew/pcb_track.h

@@ -448,7 +448,12 @@ public:
     bool HasValidLayerPair( int aCopperLayerCount );
 
     VIATYPE GetViaType() const { return m_viaType; }
-    void SetViaType( VIATYPE aViaType ) { m_viaType = aViaType; }
+    void    SetViaType( VIATYPE aViaType )
+    {
+        m_viaType = aViaType;
+        // If someone updates a VIA to TH, we want to kick out any non-outer layers
+        SanitizeLayers();
+    }
 
     const PADSTACK& Padstack() const              { return m_padStack; }
     PADSTACK& Padstack()                          { return m_padStack; }