48612 Commits

Author SHA1 Message Date
Jeff Young 9098750ba0 Debugging.
(Separate so Sentry can tell us which one fired.)
2025-07-07 12:17:10 +01:00
Jeff Young 0ccd706faf Bounds checking. KICAD-A6F. 2025-07-07 12:05:32 +01:00
Jeff Young 4e62a71448 Not all callers are expecting GUI to be put up at this level.
Potentially KICAD-RVC.
2025-07-07 11:50:03 +01:00
Jeff Young edbe570d42 Respect non-free-pads mode for Move Exactly.
(Also makes sure the filters are always in the
same order, though this may be immaterial.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/21183
2025-07-07 09:19:57 +01:00
Jeff Young c960f69a9b Equality for doubles. (Potentially KICAD-SV8) 2025-07-06 21:57:23 +01:00
Jeff Young 693ea44990 Debugging.
(Separate wxCHECKs so Sentry can tell us which
one fired.)
2025-07-06 21:42:13 +01:00
Jeff Young 9e07f1e68b Include LAYER_LOCKED_ITEM_SHADOW in PADSTACK::EffectiveLayerFor() (KICAD-V2W) 2025-07-06 21:26:13 +01:00
Jeff Young 513bdadf81 Remove noisy assert. KICAD-6XH
We may need to support showing complex numbers at some
point, but as we don't today it's sort of moot.
2025-07-06 21:26:13 +01:00
Mark Roszko 907c424f5f Set VIATYPE setting via property type as well 2025-07-06 11:17:41 -04:00
Mark Roszko c29ca703c7 Remove accidental change 2025-07-06 11:12:19 -04:00
Mark Roszko 30242cca77 Don't allow the property editor to set bad layer pairs for vias 2025-07-06 11:10:39 -04:00
Mark Roszko 1ab8a5944b Add tiny test for IsCopperLayerLowerThan 2025-07-06 11:10:39 -04:00
jean-pierre charras c1eb69570d DIALOG_LABEL_PROPERTIES: enter key close it instead of open the drop down list
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21258
2025-07-06 16:59:00 +02:00
Jon Evans db2be8f8cb Make sure initial focus of label properties dialog is the text input
(cherry picked from commit 9c28241e458bf20cd81d808b2c3480104406a8dd)

Co-authored-by: Jon Evans <jon@craftyjon.com>
2025-07-06 09:28:45 -04:00
Jeff Young 09e5afbe67 Don't ask for a string param from a frame_t event. (KICAD-THA) 2025-07-05 12:02:36 -06:00
Jeff Young b08990646c Fix format specifier (KICAD-SV6). 2025-07-05 12:02:36 -06:00
Jeff Young 96eb11cb9e Don't assume strings are non-empty (KICAD-PMX). 2025-07-05 12:02:36 -06:00
Jeff Young 9faf8b3d4c Commenting. 2025-07-05 12:02:36 -06:00
Jeff Young 275ff1cb4e Clear seleciton before removing rows. (KICAD-BER). 2025-07-05 12:02:36 -06:00
Mark Roszko 69e2c55291 Fix crash because the infobar button doesn't have a window yet (because the infobar was not shown yet on Windows), fixes sentry KICAD-X9Z 2025-07-05 13:48:09 -04:00
Mark Roszko b07fdd0e37 Add some variables to ctor initializer list for CONSTRUCTION_MANAGER
m_batchesMutex in particular needs to be ready before accptConstructionItems is called

Sentry KICAD-TYJ
2025-07-05 11:32:13 -04:00
Jeff Young 0730a0bc86 Formatting. 2025-07-04 22:13:49 -06:00
Jeff Young bf193c5ea1 Dirty connectivity when deleting via layers.
(Also dirty the document when removing blind/buried
vias.)

(This fixeds KICAD-FOY as a side-effect.)
2025-07-04 21:14:06 -06:00
Jeff Young 7bab41d746 If library was updated outside KiCad, the symbol may have been deleted. (KICAD-QZ9) 2025-07-04 19:58:13 -06:00
Jeff Young 7fc9fc5f58 Remove double-layer-processing.
(The caller already handles cycling through the
layers.)
2025-07-04 19:34:20 -06:00
Jeff Young 1e0a08034f Bounds checking (KICAD-8V9) 2025-07-04 16:40:17 -06:00
Jeff Young bacc82c589 Debugging. 2025-07-04 16:30:03 -06:00
Jeff Young dc96b99e22 Quiet assert. (KICAD-QZJ) 2025-07-04 16:19:42 -06:00
Jeff Young 7d18c237b3 Pads can be on Dwgs & Eco layers. (KICAD-RQE) 2025-07-04 16:12:41 -06:00
Jeff Young 4b510c59f9 Don't assume a schematic. (KICAD-G7S) 2025-07-04 16:12:11 -06:00
Jeff Young e1d1243a91 Don't trip over a stale sort column index. (KICAD-B3X) 2025-07-04 15:33:12 -06:00
Jeff Young 86280d5a65 Type safety (KICAD-QQT). 2025-07-04 15:23:31 -06:00
Jeff Young 9c884242f6 Clear arcs before running boolean ops (KICAD-QXG). 2025-07-04 15:14:21 -06:00
Jeff Young 1184bc3c36 Iterate pad layers when doing collisions (KICAD-R3Q). 2025-07-04 15:10:22 -06:00
Jeff Young 82d4ab5094 Don't assume a string (KICAD-8QP). 2025-07-04 13:20:41 -06:00
Jeff Young e18b4cbf72 User could lock the file at any time (KICAD-73V).
The file being locked is not a programming error.
2025-07-04 12:46:08 -06:00
Jeff Young 2a7474b33e We need to catch these when they're created. During write is too late. 2025-07-04 12:20:43 -06:00
Jeff Young 69b23df4c3 Make sure we don't end up with stale picker handlers (lots of Sentry tickets). 2025-07-04 12:10:59 -06:00
Jeff Young da9544dfd1 Attempt to patch SWIG for VIEW_ITEM::GetClass(). 2025-07-04 10:00:50 -06:00
Jeff Young 2892642516 Prevent wxWidgets assert. (KICAD-QZ5) 2025-07-03 23:26:13 -06:00
Jeff Young 4e4dfa0a38 Sort col may not be in the current columns. (KICAD-G74) 2025-07-03 23:14:35 -06:00
Jeff Young 7b0aceb99e Prevent wxWidgets assert (KICAD-6VM). 2025-07-03 22:50:56 -06:00
Jeff Young b077b32c43 Clear arcs before boolean ops (KICAD-CFQ). 2025-07-03 22:40:28 -06:00
Jeff Young 9ee5950c44 Fix a pair of copy/pastas (KICAD-JC2). 2025-07-03 22:28:16 -06:00
Jeff Young 3a8ea50783 More tool loop safety. 2025-07-03 21:49:11 -06:00
Jeff Young ee097a7073 ADDED: row height and column width property inspector properties.
(This time for SCH tables.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/21224
2025-07-03 21:07:14 -06:00
Jeff Young 0375985d58 Debugging for removing items not in the view. 2025-07-03 20:45:11 -06:00
Jeff Young a7319bfcd0 Tool loop safety. 2025-07-03 20:01:35 -06:00
Jeff Young 6f7023116d Static_cast safety. 2025-07-03 19:41:52 -06:00
Jeff Young 54cfb62597 Double check file dlg results on MSW. 2025-07-03 17:35:34 -06:00